<html>
<head><meta charset="utf-8"><title>Does glacier push the regression test to the main repo? · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html">Does glacier push the regression test to the main repo?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="223087748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223087748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> osa1 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223087748">(Jan 18 2021 at 07:23)</a>:</h4>
<p>glacier's README says</p>
<blockquote>
<p>This repository is used to test internal compiler errors (also known as ICEs) in Rust. An ICE means that something went wrong, something unexpected. As such, sometimes, ICEs get randomly fixed. A compiler refactoring will remove the odd code path, even if the point of the change wasn’t to fix the bug.</p>
<p>As such, this repository is a collection of these bugs, and it runs on Rust nightly, once a day, through GitHub Actions. If any of the ICEs stop happening, the build will fail, and I can close the associated bug.</p>
</blockquote>
<p>This just says it'll close the bug report, but doesn't say what happens to the regression test that was added to glacier. Will it push it to the main repo? If not, how do we know if an ICE that was unintentionally/accidentally fixed is re-introduced later?</p>



<a name="223097735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223097735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223097735">(Jan 18 2021 at 09:37)</a>:</h4>
<p>It only checks if the bug is fixed. Nothing less, nothing more.</p>



<a name="223097850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223097850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223097850">(Jan 18 2021 at 09:38)</a>:</h4>
<p>The source of glacier is really small.</p>



<a name="223105815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223105815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> osa1 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223105815">(Jan 18 2021 at 10:57)</a>:</h4>
<p>Got it. It's a bit unfortunate that if a ICE is fixed unintentionally or accidentally we won't have a test for it.</p>



<a name="223107664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223107664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223107664">(Jan 18 2021 at 11:18)</a>:</h4>
<p>The issue is never closed automatically</p>



<a name="223107701"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223107701" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223107701">(Jan 18 2021 at 11:19)</a>:</h4>
<p>If we think the issue needs a test, we will add a test (manually)</p>



<a name="223108505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223108505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> osa1 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223108505">(Jan 18 2021 at 11:27)</a>:</h4>
<p>Oh, OK. "I can close the associated bug" I read this as if it's closing the bug report.</p>



<a name="223108571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223108571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> osa1 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223108571">(Jan 18 2021 at 11:28)</a>:</h4>
<p>So it's just adding a comment to the bug report saying that it no longer causing an ICE?</p>



<a name="223116127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223116127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223116127">(Jan 18 2021 at 12:56)</a>:</h4>
<p>I think the bot opens a PR on glacier to move the ICE test case to a "fixed" directory</p>



<a name="223116408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223116408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223116408">(Jan 18 2021 at 12:59)</a>:</h4>
<p>See for example glacier#617</p>



<a name="223157351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Does%20glacier%20push%20the%20regression%20test%20to%20the%20main%20repo%3F/near/223157351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Does.20glacier.20push.20the.20regression.20test.20to.20the.20main.20repo.3F.html#223157351">(Jan 18 2021 at 19:37)</a>:</h4>
<p>Yeah, the bot doesn't close the issue; it just opens a PR to move it to fixed and then the human who merges the PR can decide to close the issue if that makes sense.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>